Home → Suggestions →

New Desktop Application

• Edit

sean64

24 Jan, 2015 08:11 AM

Hi

First of all: nice work on the software collection! I really like the concept.

I created a compatible desktop application based on Qt. You find it here: https://github.com/bkueng/qMasterPassword. It has most of the features of the Java version (except password verification) plus some more, like system tray icon, categories, and data export. Furthermore it is cross-platform.

Let me know what you think

1. Support Staff 1 Posted by Maarten Billemo... on 24 Jan, 2015 02:45 PM

   

   Looks interesting, Sean.

   Would it be possible to change the code such that you depend on the standard C implementation instead of re-implementing it? That way, you'd mainly be a front-end and not responsible for ensuring there are no bugs in your crypto implementation. Our C code is also well tested.

   For instance, does string.length() result in the amount of bytes in the string or the amount of characters? The latter would result in bad passwords for multi-byte names.

   • Edit

2. 2 Posted by sean64 on 24 Jan, 2015 03:39 PM

   

   I guess it would be possible. However my idea was to add unit tests (I saw you have some based on xml). This would then also ensure correctness for the higher-level code, like the Qt string class QString.

   If I used your C implementation, I suggest you split off the relevant code into a separate tiny libarary in a new repo. This would make the code more reusable and there would be a clear interface.

   The std::string class does not care about encodings, so string::length() is always equal to the number of bytes. I tested my code with german umlautes, which are 2 bytes in UTF8, and it gives the same results as your implementation. Note that Qt uses UTF16, so I made sure that for the crypto methods strings are always converted to/from UTF8 to ensure correctness.

   • Edit

3. Support Staff 3 Posted by Maarten Billemo... on 24 Jan, 2015 04:03 PM

   

   Sounds good. For using the standard C code, you'd essentially just depend on an mpw-cli version, the current one being https://ssl.masterpasswordapp.com/mpw-2.1-cli4-0-gf6b2287.tar.gz
   From the archive, you'd include mpw-algorithm.h, and maybe mpw-util.h.

   I can think about moving this stuff into a submodule, but that won't be for tomorrow.

   • Edit

4. 4 Posted by sean64 on 31 Jan, 2015 11:03 AM

   

   Ok that's not very urgent. I added unit tests now, based on your xml file.

   Also there is now a binary version for Windows: https://github.com/bkueng/qMasterPassword/releases

   • Edit

5. 5 Posted by cake on 01 Feb, 2015 08:31 PM

   

   Hi,

   I like it! Now i can manage my logins with one tool.
   The login table was very useful. So dont need keepass anymore for the loginnames.

   best regards

   • Edit